WRR-4972: Fixed `PageViews` and `QuickGuidePanels` dot page indicators to be aligned center

enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs

Apache License 2.0

22 stars 3 forks source link

Checklist

[x] I have read and understand the contribution guide
[x] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added

The dot type page indicators in PageViews seems not center aligned.

Resolution

We've tried to adjust align with the icon font but it's hard to implement with font. So I implemented with pure div with CSS style instead of Icon component.

Additional Considerations

I've modified QuickGuidePanels too since it's also using Steps to show page indicators. I think we need to make a new component "PageIndicator" rather than using Steps eventually. I'll make another ticket for this.

Links

WRR-4972

Comments

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.81%. Comparing base (2ac7a6a) to head (b518f3a). Report is 1 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1730 +/- ## =========================================== + Coverage 80.79% 80.81% +0.01% =========================================== Files 148 148 Lines 6677 6681 +4 Branches 1985 1986 +1 =========================================== + Hits 5395 5399 +4 Misses 973 973 Partials 309 309 ```

enactjs / sandstone