enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-6383: Convert Spinner/SpinnerSpotlightDecorator to functional component #1733

Closed stanca-pop-lgp closed 5 days ago

stanca-pop-lgp commented 1 month ago

Checklist

Issue Resolved / Feature Added

At this moment, Spinner/SpinnerSpotlightDecorator is a hoc based on a class component. The goal is to convert it to a functional component.

Resolution

Converted Spinner/SpinnerSpotlightDecorator from class to functional component.

Additional Considerations

Links

WRR-6383

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.73%. Comparing base (a4d543d) to head (e0aa964). Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
Spinner/Spinner.js 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1733 +/- ## =========================================== + Coverage 81.55% 81.73% +0.18% =========================================== Files 148 148 Lines 6673 6741 +68 Branches 1985 2010 +25 =========================================== + Hits 5442 5510 +68 Misses 938 938 Partials 293 293 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: