enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-6380: Converted Popup/Popup to functional component #1734

Open ion-andrusciac-lgp opened 1 month ago

ion-andrusciac-lgp commented 1 month ago

Checklist

Issue Resolved / Feature Added

At this moment, Popup/Popup is based on a class component. The goal is to convert it to a functional component.

Resolution

Converted Popup/Popup to functional component

Additional Considerations

Links

WRR-6380

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 86.13861% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (067a69b) to head (5b0556d). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
Popup/Popup.js 86.13% 12 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1734 +/- ## =========================================== + Coverage 80.81% 80.83% +0.02% =========================================== Files 148 148 Lines 6681 6695 +14 Branches 1986 1987 +1 =========================================== + Hits 5399 5412 +13 - Misses 973 974 +1 Partials 309 309 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.