enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-6697: Fix node_js to use lts version only on travis #1736

Closed hong6316 closed 2 weeks ago

hong6316 commented 3 weeks ago

Checklist

Issue Resolved / Feature Added

npm intall not working on node v23 because of node-canvas https://github.com/enactjs/sandstone/pull/1723/checks?check_run_id=31623413345

So we decided to change the node version to lts/*

Resolution

Fix node_js to use lts version only on travis

Additional Considerations

Links

WRR-6697

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.81%. Comparing base (067a69b) to head (847e551). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1736 +/- ## ======================================== Coverage 80.81% 80.81% ======================================== Files 148 148 Lines 6681 6681 Branches 1986 1986 ======================================== Hits 5399 5399 Misses 973 973 Partials 309 309 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

0x64 commented 2 weeks ago

Note that lts version is 22 as of now. Due to unstable dependencies whenever a major version of node, we'd like to use lts for Travis CI.