enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-9101: Fixed `Input` keypad layout in largeText mode #1738

Closed vJIYEv closed 1 week ago

vJIYEv commented 2 weeks ago

Checklist

Issue Resolved / Feature Added

With portrait fullscreen or overlay type, keypad of number type input should have 3 columns. But in largeText mode, keypad has 2 columns now.

Resolution

This is because width is set to exactly fit normal mode. I added keypad width values for largeText mode in portrait fullscreen & overlay type.

Additional Considerations

Links

WRR-9101

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.84%. Comparing base (54fb2e3) to head (8445dd3). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1738 +/- ## ======================================== Coverage 80.84% 80.84% ======================================== Files 148 148 Lines 6687 6687 Branches 1990 1990 ======================================== Hits 5406 5406 Misses 972 972 Partials 309 309 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.