Closed mmyelyn closed 2 days ago
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 80.93%. Comparing base (
d0d3384
) to head (4db12f9
). Report is 8 commits behind head on release/2.9.x.develop.
Files with missing lines | Patch % | Lines |
---|---|---|
useScroll/useEvent.js | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checklist
Issue Resolved / Feature Added
When scrolling down with voice control in certain apps, focus is not restored. Currently, when scrolling with voice control, focus is moved only when the bounds of the viewport include all bounds of the node.
Therefore, it is necessary to handle the case where the node's bounds are not all included in the viewport's bounds. (when there is a large node that goes out of bounds, the upper part is visible but the lower part is cut off, etc.)
Resolution
Added focus logic for cases where the top of the node is long and the bottom of the node is long using node Bounds and viewports Bounds. Since I need to receive and check new nodes, I implemented it using a recursive function.
Additional Considerations
Links
WRR-9115
Comments
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)