enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-6683: Remove logic to focus a slider when dragging with touch #1751

Closed 0x64 closed 4 days ago

0x64 commented 1 week ago

Checklist

Issue Resolved / Feature Added

When a user drags a slider with touch to move the slider, a console error occurs. image

Resolution

The console error occurs because a ref is not properly passed to ui/Slider so I created the patch first. But, after investigation and tests, I concluded that the logic using the ref is actually not needed anymore. Therefore, I want to remove the issued logic.

Additional Considerations

The issued logic is to focus a slider knob even a user touch slightly out of the slider knob to show a focus effect on the knob. We don't need this in the current Sandstone.

Links

WRR-6683

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.91%. Comparing base (d2b9211) to head (a20bcfb). Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1751 +/- ## =========================================== + Coverage 80.84% 80.91% +0.06% =========================================== Files 148 148 Lines 6687 6679 -8 Branches 1990 1988 -2 =========================================== - Hits 5406 5404 -2 + Misses 972 967 -5 + Partials 309 308 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: