enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-387: `Panels`: Updated documentation for arranger #1752

Open vJIYEv opened 6 days ago

vJIYEv commented 6 days ago

Checklist

Issue Resolved / Feature Added

Default value of arranger prop in Sandstone/Panels does not match the documentation. Documentation says the default is ui/ViewManager.SlideLeftArranger, but actual value is BasicArranger from internals/Panles/Arrangers.js.

Resolution

Default value was changed in https://github.com/enactjs/sandstone/pull/315 from SlideLeftArranger to BasicArranger but BasicArranger is for internal use. So instead of updating documentation of arranger in Sandstone/Panels, I updated documentation of BasicArranger to explain what it is.

Additional Considerations

Links

WRR-387

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.21%. Comparing base (3ad4630) to head (8e5369d). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1752 +/- ## =========================================== + Coverage 80.80% 81.21% +0.40% =========================================== Files 148 148 Lines 6675 6807 +132 Branches 1985 2061 +76 =========================================== + Hits 5394 5528 +134 + Misses 972 970 -2 Partials 309 309 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.