enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-12000: Enhanced ColorPicker code and made component public #1759

Open stanca-pop-lgp opened 4 days ago

stanca-pop-lgp commented 4 days ago

Checklist

Issue Resolved / Feature Added

ColorPickerPOC component needs improvements:

Resolution

Performed enhancements on ColorPickerPOC component:

Additional Considerations

Links

WRR-12000

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 41.17647% with 150 lines in your changes missing coverage. Please review.

Project coverage is 76.53%. Comparing base (8d7037c) to head (1aa06ac).

Files with missing lines Patch % Lines
ColorPicker/utils.js 0.00% 56 Missing and 14 partials :warning:
ColorPicker/ColorPicker.js 0.00% 53 Missing and 14 partials :warning:
ColorPicker/ColorPickerSlider.js 0.00% 6 Missing :warning:
ColorPicker/ColorPickerSpectrum.js 0.00% 4 Missing :warning:
ColorPicker/ColorPickerGrid.js 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/ColorPickerPOC #1759 +/- ## ========================================================== + Coverage 76.31% 76.53% +0.21% ========================================================== Files 154 154 Lines 7072 7052 -20 Branches 2061 2056 -5 ========================================================== Hits 5397 5397 + Misses 1304 1290 -14 + Partials 371 365 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stanca-pop-lgp commented 4 days ago

Tests will be added in a separate ticket.