Closed paul-beldean-lgp closed 3 months ago
the web-vitals upgrade for moonstone template is missing. please add it
UiSlotItem
and UiToggleItem
and remove SlotItem
and ToggleItem
.
Enact v5 removed them so packages/theme
also should follow those changes.Additional Considerations
, Please add major-updated modules'(web-vitals
, electron
, and ramda
) change logs, includes the migration guide.
- Please revert adding
UiSlotItem
andUiToggleItem
and removeSlotItem
andToggleItem
. Enact v5 removed them sopackages/theme
also should follow those changes.- In
Additional Considerations
, Please add major-updated modules'(web-vitals
,electron
, andramda
) change logs, includes the migration guide.
I made the changes. For electron v31 there is no upgrade guide.
Checklist
Issue Resolved / Feature Added
Updated node modules major versions
Resolution
Updated node modules major versions
Additional Considerations
Replaced "getCLS, getFID, getFCP, getLCP, getTTFB" with "onCLS, onFID, onFCP, onLCP, onTTFB" because they were deprecated and replaced with the new ones. Replaced "ReportHandler" type with "(metric: MetricType) => void" because it was deprecated. Removed SlotItem and ToggleItem as ui/SlotItem and ui/ToggleItem were removed from enact/ui 5.0.0 and removed CheckboxItem and RadioItem because they were using ToggleItem. Added node engine version to electron template.
Change logs: web-vitals v4.0.0 https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md#v400-2024-05-13 Update types to support more generic usage Split waitingDuration to make it easier to understand redirect delays Rename TTFBAttribution fields from Time to Duration Rename resourceLoadTime to resourceLoadDuration in LCP attribution Add INP breakdown timings and LoAF attribution Deprecate onFID() and remove previously deprecated APIs Expose the target element in INP attribution Save INP target after interactions to reduce null values when removed from the DOM Cap TTFB in attribution Fix reportAllChanges behavior for LCP when library is loaded late upgrading: https://github.com/GoogleChrome/web-vitals/blob/main/docs/upgrading-to-v4.md
electron v31.0.0 https://github.com/electron/electron/releases/tag/v31.0.0 Made window.flashFrame(bool) flash continuously on macOS. Updated Chromium to 126.0.6445.0. (Removed: WebSQL support) Updated Chromium to 125.0.6412.0. (Behavior Changed: nativeImage.toDataURL will preserve PNG colorspace)
ramda v0.30.0 https://github.com/ramda/ramda/issues/3453 use === to test for placeholder
Links
WRQ-27790
Comments
Enact-DCO-1.0-Signed-off-by: Paul Beldean paul.beldean@lgepartner.com