search

enaml-ops / omg-cli

it's kind of like an (o)ps (m)anager in (g)olang
Apache License 2.0
15 stars 11 forks source link

using --bosh-private-ip and no --bosh-public-ip means static ip is put into both fields. #9

Closed haydonryan closed 8 years ago

haydonryan commented 8 years ago 
./omg-linux azure \
  --azure-vnet boshvnet-crp \
  --azure-subnet Bosh \
  --azure-subscription-id <Redacted> \
  --azure-tenant-id <Redacted>  \
  --azure-client-id <Redacted> \
  --azure-client-secret amazon4ever \
  --azure-resource-group hrcentral \
  --azure-storage-account <Redacted> \
  --azure-security-group nsg-bosh \
  --azure-ssh-pub-key-path bosh-privatekey.pub \
  --azure-ssh-user vcap \
  --azure-environment AzureCloud \
  --azure-private-key-path bosh-privatekey \
  --cpi-name cpi \
  --bosh-private-ip 10.0.0.5

output of the command results in a manifest with:

  - name: private
    static_ips:
    - 10.0.0.5
    default:
    - dns
    - gateway
  - name: public
    static_ips:
    - 10.0.0.5

This is incorrect. OMG should allow for a bosh deployed to a subnet that is not public (ie when using a jumpbox / bastion box to deploy bosh).

calebwashburn commented 8 years ago

Fixed by using private IP for all config unless public IP is provided. Will be included in next cut release.

calebwashburn commented 8 years ago

Included in draft release - https://github.com/enaml-ops/omg-cli/releases/tag/untagged-45f4bbccfcde67ea75d2