search

enaml-ops / omg-product-bundle

a bundle of supported omg compatible product plugins
Apache License 2.0
2 stars 2 forks source link

Product plugins should reside in their own repositories #12

Open ghost opened 8 years ago

ghost commented 8 years ago

Product plugins should reside in their own repositories. This is particularly important for Concourse pipelines that use the github-release resource to check for updates. Having all plugins in the same github release means that a change in any plugin results in a resource check state change which may then trigger a deployment, even if the plugin used in the pipeline was not updated.

For example: Say the cloud foundry plugin is used in a Concourse pipeline, and then a pmysql plugin update is pushed. A new omg-product-bundle release is created, but only to push the new pmysql update. Since the cloud foundry plugin is bundled in that same release, the Concourse Cloud Foundry pipeline sees the change and may trigger an update even though it's very likely an unrelated change--the change was for mysql.

xchapter7x commented 8 years ago

i agree, and long term they will.

we opted to bundle them into a single repo while we flesh out a more stable plugin interface. It's just easier to manager this way, for now.

we have a lot of feedback and a lot of good guidance on what a v1.0 plugin should look like. when we get there, these will all be their own repos.

2016-09-17 15:44 GMT-04:00 Mike Jacobi notifications@github.com:

Product plugins should reside in their own repositories. This is particularly important for Concourse pipelines that use the github-release resource to check for updates. Having all plugins in the same github release means that a change in any plugin results in a resource check state change which may then trigger a deployment, even if the plugin used in the pipeline was not updated.

For example: Say the cloud foundry plugin is used in a Concourse pipeline, and then a pmysql plugin update is pushed. A new omg-product-bundle release is created, but only to push the new pmysql update. Since the cloudfoundry is bundled in that same release, the Concourse Cloud Foundry pipeline sees the change and may trigger an update even though it's very likely an unrelated change--the change was for mysql.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/enaml-ops/omg-product-bundle/issues/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqI0zrXFh-00yjy1DPHij7LiIJ6opdOks5qrEMsgaJpZM4J_sbl .