search

enarx-archive / sev

Library for AMD SEV
Apache License 2.0
20 stars 15 forks source link

Add serde support #33

Closed connorkuehl closed 4 years ago

connorkuehl commented 4 years ago

Derive serde support for relevant attestation types (except certificates)

Reasoning pasted from another PR:

NOTE: it's CBOR-encoding all the way down, now, forget about the two modes of encoding (CBOR or opaque blob). I flew too close to the sun. The only exception is the certificate payloads. These are blobs. Their structure is well-defined in the AMD spec and it is ironically more work for a client not using our tooling to encode them as CBOR than it would be for them to simply send them in blob form.

connorkuehl commented 4 years ago

Converting to a draft. I suspect there's a bug somewhere in here because when I reverted the serde serialization/deserialization from my remote attestation PR the release build worked with just binary encoding/decoding.

connorkuehl commented 4 years ago

Okay. I pivoted here. Check opening comment for more information on what's changed. No more manual serde implementations to review here.