search

enarx-archive / sev

Library for AMD SEV
Apache License 2.0
20 stars 15 forks source link

Add a high-level SEV launch API #5

Closed connorkuehl closed 4 years ago

connorkuehl commented 4 years ago

Closes https://github.com/enarx/enarx/issues/818

connorkuehl commented 4 years ago

Will address the conditional compilation stuff in the morning :sleeping:

connorkuehl commented 4 years ago

Mostly just a few nits.

My biggest question is what is happening with pin_pages(). It seems to be attached to both the Handle and Launcher objects; but doesn't really use either of them. What's the plan here?

@npmccallum I'll remove its association with Launcher; that is a consequence of my misunderstanding this morning with LaunchStart.

I associated it with Handle because that is the type of return value you get at the end of a successful launch and so I thought I could retain access to that to call pin_pages when the KVM guest is attempting to balloon memory.

npmccallum commented 4 years ago

@connorkuehl It might just be best to move it out of the sev crate altogether.

connorkuehl commented 4 years ago

Latest push addresses Harald's feedback.

No other changes.