search

enarx-archive / sev

Library for AMD SEV
Apache License 2.0
20 stars 15 forks source link

Re-shape PlatformStatus into sev_user_data_status #61

Closed connorkuehl closed 3 years ago

connorkuehl commented 3 years ago

This struct must take the form of the sev_user_data_status struct that the AMD SEV kernel module exports. Right now, it resembles the command buffer that the kernel is meant to send to the firmware; which is wrong because the struct exported by the kernel and the command buffer that the firmware expects are different. This results in data loss (most recently observed in losing information in the flags variable).

For example, when running sevctl show flags on Rome (without this patch):

[connorkuehl@rome sevctl]$ cargo run -- show flags Compiling sevctl v0.1.0 (/home/connorkuehl/git/sevctl) Finished dev [unoptimized + debuginfo] target(s) in 2.16s Running target/debug/sevctl show flags owned

^^^ Note that the "es" flag we expect to see is missing.

With this patch:

[connorkuehl@rome sevctl]$ cargo run -- show flags Compiling sev v0.1.0 (/home/connorkuehl/git/sev) Compiling sevctl v0.1.0 (/home/connorkuehl/git/sevctl) Finished dev [unoptimized + debuginfo] target(s) in 3.27s Running target/debug/sevctl show flags owned es

Signed-off-by: Connor Kuehl ckuehl@redhat.com

connorkuehl commented 3 years ago

I don't know where the rest of the CI went :thinking:

edit: my UI shows 8 checks pending but when I look at the runs manually in the actions tab, all of them have returned green.

haraldh commented 3 years ago

I don't know where the rest of the CI went thinking

edit: my UI shows 8 checks pending but when I look at the runs manually in the actions tab, all of them have returned green.

That is odd... in the branch protection settings all looks good either.

haraldh commented 3 years ago

I don't know where the rest of the CI went thinking edit: my UI shows 8 checks pending but when I look at the runs manually in the actions tab, all of them have returned green.

That is odd... in the branch protection settings all looks good either.

@connorkuehl @npmccallum seems like we have to wait at least one week, to be able to enable the correct tests, as they are currently listed with the exact same name... very annoying.

haraldh commented 3 years ago

I don't know where the rest of the CI went thinking edit: my UI shows 8 checks pending but when I look at the runs manually in the actions tab, all of them have returned green.

That is odd... in the branch protection settings all looks good either.

@connorkuehl @npmccallum seems like we have to wait at least one week, to be able to enable the correct tests, as they are currently listed with the exact same name... very annoying.

Or we just rename the tests a little bit, so we are able to pick the current ones.