enarx / ciborium

CBOR utilities
Other
222 stars 54 forks source link

fix: is_human_readable should be false #80

Closed sdbondi closed 1 year ago

sdbondi commented 1 year ago

CBOR is not a human-readable format and so is_human_readable should be overridden in the Serializer and Deserializer traits, which return true by default.

https://docs.rs/serde/latest/serde/trait.Deserializer.html#method.is_human_readable

sdbondi commented 1 year ago

This wasn't the problem I initially thought it was :) Feel free to close if you disagree with this change.

nakedible-p commented 1 year ago

Please implement this pull. It is correct that the output is not human readable, and I plan to use this distinction.