search

enb / enb-bemxjst

bem-xjst support for ENB
Other
22 stars 19 forks source link

Proposal: add [version] to BEMHTML #198

Closed Yeti-or closed 7 years ago

Yeti-or commented 8 years ago

In dev build add version prop to BEMHTML instance, with version of bem-xjst we build on.

blond commented 8 years ago

In bem-xjst@4+ has no dev mode.

We can add option (for example provideVersion: true) and use it in ENB development mode.

miripiruni commented 8 years ago

@Yeti-or can you provide usecase for version prop?

qfox commented 8 years ago

@miripiruni The same as process.version

qfox commented 8 years ago

@blond Are you sure we should extend BEMHTML instance in dev mode? It's ok for me but also it's strange to hear that from you. 😸

miripiruni commented 8 years ago

@zxqfox can you describe more? I don’t understand the target issue.

qfox commented 8 years ago

@miripiruni Describe what?) How it's useful to see a version from the repl?

miripiruni commented 8 years ago

@zxqfox Okay. The only question is: you accidentally do not intend to use it as a "feature detection"?

qfox commented 8 years ago

@miripiruni Well, sure not. But it's useful for debugging and informational purposes. Anyway I'm against adding this to production build.

miripiruni commented 8 years ago

@zxqfox 👍

blond commented 8 years ago

Are you sure we should extend BEMHTML instance in dev mode? It's ok for me but also it's strange to hear that from you. 😸

@zxqfox I think every man able to decide where to use option.

qfox commented 8 years ago

I think every man able to decide where to use option.

Liberty is the new freedom, lol.

miripiruni commented 7 years ago

Any normal developer can do require('bem-xsjt/package.json').version or npm ls | grep bem-xjst.

We don’t need version field and moreover option (provideVersion: true) for this. It’s useless and weird.