search

enb / enb-bh

BH support for ENB
Other
15 stars 12 forks source link

bhOptions #119

Closed blond closed 9 years ago

blond commented 9 years ago

Use bhOptions instead of all options for provide to core:

This change will allow:

  1. We do not need to release new versions of enb-bh if released minor versions of bh with new option.
  2. Test bh package before its release (see #118)
sipayRT commented 9 years ago

:+1:

qfox commented 9 years ago

Would you mind to declare peer dep for bh?

blond commented 9 years ago

Would you mind to declare peer dep for bh?

What for?

qfox commented 9 years ago

Just to declare what version of bh it supports. NPM won't install it if it declared since https://github.com/npm/npm/issues/6565#issuecomment-74971689 — so it will be pretty usable in 3.0

blond commented 9 years ago

I think that it will be useful when most users will use npm@3.0. Now it will bring more problems than profit.

qfox commented 9 years ago

Ye, forgot about node 0.12 users. ;-( sorree