search

enb / enb-sass

MIT License
12 stars 7 forks source link

Upgrade node-sass #4

Open ixax opened 9 years ago

ixax commented 9 years ago

Requested features: https://github.com/google/material-design-lite/blob/master/src/button/_button.scss#L17 (actually the file is here: https://github.com/google/material-design-lite/blob/master/src/_variables.scss)

DimitryDushkin commented 9 years ago

+1

tadatuta commented 9 years ago

:+1:

dab commented 9 years ago

:+1:

sipayRT commented 9 years ago

:+1:

ixax commented 9 years ago

Got it! At this weekend will try to build and upload a release :bomb:

DimitryDushkin commented 9 years ago

It also can be closed

ixax commented 9 years ago

No, it can't. @tadatuta try this branch https://github.com/enb-make/enb-sass/tree/imports

tadatuta commented 9 years ago

There are still some problems in imports branch :(

@veged got a case with broken import resolving and as a result this loop never ended (and error was never caught and logged).

Will try to find some time to provide minimal test case.

veged commented 9 years ago

I suggest to change here https://github.com/enb-make/enb-sass/commit/fadbe64a19766c34627676d6c41b8d02d842c4c6#diff-09f26496655e6744ced8766d49bdb26bL72 while (!filename && i > 0) {

but there are still cases when var searchString = ': begin */' may be not found in all content, so later https://github.com/enb-make/enb-sass/commit/fadbe64a19766c34627676d6c41b8d02d842c4c6#diff-09f26496655e6744ced8766d49bdb26bL81 filename[1] cause exception