search

enbility / eebus-go

EEBUS protocol implementation in go
https://enbility.net
MIT License
52 stars 14 forks source link

Fix ma/mpc usecase to validate the correct actor type #107

Closed sthelen-enqs closed 2 weeks ago

sthelen-enqs commented 2 weeks ago

The ma/mpc usecase should filter for actors of type MonitoredUnit but was filtering for actors of type MonitoringAppliance which lead to the uc never finding any entities.

This PR also adds a commit which adjusts the string representation of the ma/mpc UseCaseSupportUpdate EventType from "ma-mpc-oscev-UseCaseSupportUpdate" to "ma-mpc-UseCaseSupportUpdate" as it isn't relevant here. This is technically an API-breaking change, but all subscribers should be using the constant mpc.UseCaseSupportUpdate instead of its string representation and therefore automatically always use the correct variant for their version of eebus-go. I could, however, drop the commit from this PR if preferred.

DerAndereAndi commented 2 weeks ago

Nice catch @sthelen-enqs . Thank you!