Open sthelen-enqs opened 2 weeks ago
Thanks a lot for the PR!
Some first thoughts, more will surely come:
Having individual public functions for each scenario is what surely is expected and needed. But using those individually will result in a notify update message for each call, which I think is not nice.
I do see 2 options here:
Regarding initialization: how about the possibility to define the supported scenarios, and for each scenario define a configuration item where items like amount of phases, measurement type, reference to etc. needs to be set.
Scenario 1 is required, all other scenarios are option/recommended. And even within the scenarios there are optional items, e.g. phase specfiic power.
Also I am wondering you only added setters, but maybe it is also helpful to have getters to e.g. validate the current storage?
This adds an implementation of the MPC use case for Monitored Units.
The current implementation has 2 major restrictions so far:
I'm opening this as a Draft PR because while this UC works, it can still be improved and I'm looking for feedback and potential improvements. Some of the areas I'm explicitly looking for feedback in are: