search

enbility / eebus-go

EEBUS protocol implementation in go
https://enbility.net
MIT License
52 stars 14 forks source link

Heartbeat DeviceDiagnosis feature allowed on non DeviceDiagnosis featuretype ? #58

Closed DerAndereAndi closed 8 months ago

DerAndereAndi commented 1 year ago

The Elli wallbox implements the Heartbeat Diagnosis client Feature on a Generic featuretype, see https://github.com/enbility/devices/blob/main/elli/charger-connect-pro/discovery-data.json#L716-L741

The Overload Protection by EV Charging Current Curtailment spec V1.0.1 defines in 3.2.2.1 the feature to be implemented in featureType DeviceDiagnosis for the role server. In 3.2.1.1 it is defined for featureType any for the role client.

Why is that different? Why should this be allowed to be implemented in a non DeviceDiagnosis featureType?

DerAndereAndi commented 8 months ago

This is expected as the client side of a SPINE feature may be implemented in a Generic featureType. It is even recommended to do that. For this repository I disagree with this recommendation and don't actively support setting this up. But the implementation can handle it, if the remote device uses this.