Closed frac2738 closed 3 months ago
Hi @frac2738,
Thank you for bringing this up! Let me have a quick look and get back to you!
Enrique
Hi @frac2738,
This seems to be an odd bug that somehow it is not showing up in my environment. I might need some time to further delve into it and see what is breaking on another environment that reproduces the bug.
Before that, could I ask you to quickly download the latest commit from GitHub and check again if legend titles are still missing?
devtools::install_github("enblacar/SCpubr", ref = "488c3aadd9876eb404cbdb80c844049fda67ca02")
Thanks a lot! Will keep you updated on this. Enrique
Hi @enblacar, thanks for taking the time to looking into this bug.
I upgrade the version I had to the last commit (SCpubr_2.0.2.9000
), and the behaviour did not change
exp_Integrated <- readRDS("int_B-only.Rds")
b_markers <- read.csv("B_markers.txt")
do_FeaturePlot(exp_Integrated, features = b_markers$IG_genes, legend.position = "right")
Hi @frac2738,
Interesting. Even if I download the CRAN version, it works fine within my system environment. I will have to delve into this with some more time. Thanks again for bringing this up and for the help!
Enrique
Hi @frac2738,
I have committed a hotfix that probably solves the issue. To be honest, this was a rather hard to reproduce bug, as it only happened in some devices while in others not (also tested in other colleague's RStudio sessions).
Could you please give it a go downloading SCpubr
with the latest commit and let me know if this fixed your issue? If so, it will roll out in the next update of SCpubr
.
devtools::install_github("enblacar/SCpubr" ref = "e9eace273bec3e6518f82a091378bc2e380e5489")
Looking forward to the answer! Enrique
I will do more testing in the coming days, but it seems to work now.
> do_FeaturePlot(exp_Integrated,c("CD8A","CD3E"),
+ order = TRUE, viridis.palette = "D",use_viridis = TRUE,
+ viridis.direction = -1, legend.position = "right", legend.length = 8)
Thank you for fixing it this quickly!
Hi @frac2738,
Great news! Happy that it worked.
I will close this issue now. Please feel free to open a new issue if you encounter anything else. Given how obscure this error was to my checks, I could foresee other similar ones popping up in other functions. If you encounter them, I would really appreciate if you let me know!
Best, Enrique
It has been a while that
do_FeaturePlot
has a strange behaviour. The legend title is not displayed anymore.The code above returns a figure without the legend title
This make difficult to know which one is which. Of course I know that the left is "nFeature_RNA" and the right is "nCount_RNA", but this can be problematic when the figures are shared.
So far a workaround is to add the title to the single plots and then combine them together
I tried to re-install
SCpubr
multiple times, but nothing has changed. I don't think this is an intended behaviour...is that correct?