Set ownership of /app/data directory to note-mark user in Dockerfile

enchant97 / note-mark

Note Mark is a lighting fast and minimal; web-based Markdown notes app.

https://notemark.docs.enchantedcode.co.uk/

GNU Affero General Public License v3.0

297 stars 6 forks source link

Set ownership of /app/data directory to note-mark user in Dockerfile #171

Closed NavyStack closed 8 months ago

NavyStack commented 8 months ago

This change ensures that the note-mark user has the necessary permissions to access and modify the /app/data directory within the container, addressing potential permission issues with the SQLite database file.

enchant97 commented 8 months ago

Closing because:

This project uses npm for package management not pnpm.
Lots of changes not related to original PR
Why rewrite the dockerfile completely
tini not needed
defaults for environment variables have been changed
uses debian for final image and not static debian (a distroless image)
setting specific user in image not needed

NavyStack commented 8 months ago

You have the freedom to choose any method you prefer, as each comes with its own set of trade-offs. However, the notion that this method is confined to 'setting specific user' is simply incorrect.

I'm already utilizing images from various repositories, which source from the current repository but with altered permissions. Additionally, I've adjusted the settings to address potential PID issues.

This is in compliance with AGPL 3.0.

NavyStack commented 8 months ago

You can check https://github.com/NavyStack/mark-note-ns/blob/d9758ce4f26c593880a22afdda7f95f5239be76e/Dockerfile

and Happy New Year !