search

encode / apistar

The Web API toolkit. 🛠
https://docs.apistar.com
BSD 3-Clause "New" or "Revised" License
5.57k stars 411 forks source link

WIP Pipenv integration #554

Closed sultaniman closed 6 years ago

sultaniman commented 6 years ago

In this PR I am evaluating how well pipenv will work out with APIStar build/ci/test stages.

audiolion commented 6 years ago

from a topic I was reading on this, you aren't supposed to use a Pipfile / Pipfile.lock for libraries because they force the installer to use specific hashes of dependencies and due to dependency tree rules can cause some people to not be able to install. I believe the recommendation was to have dependency information in the setup.py file

jgirardet commented 6 years ago

You should keep pipfile, not pipfile.lock. wild card dependency are dangerous because it might break with majors release of a dependency

sultaniman commented 6 years ago

Thanks for reviews, so next things to do are

  1. Ignore lock file,
  2. May be discuss freezing/pinning dependencies from requirements.txt and setup.py

Also have a question regarding mypy linting may be we need to suppress some warning because they are redundant and Travis checks failing because of it?

Thanks.

tomchristie commented 6 years ago

There's a lot of unrelated changes in here. I think any PR here should just replace the existing requirements.txt with a Pipfile, and adjust the scripts/* accordingly.

sultaniman commented 6 years ago

@tomchristie @audiolion @jgirardet then I will do another PR with related changes. Thanks for your time guys!