Open abn opened 5 years ago
@tomchristie - hoping that the implementation in a7f8518 is aligned to what you had in mind for the TODO. The other two commits are not related to that change but were added to handle CI failures. Happy to field any feedback.
Looks good actually! It'd need bringing up to date, but otherwise I think we'd be able to have this in (apologies for the delay!)
@tomchristie no worries; I will get it rebased soon-ish.
@tomchristie - hoping that the implementation in a7f8518 is aligned to what you had in mind for the TODO. The other two commits are not related to that change but were added to handle CI failures. Happy to field any feedback.