encode / broadcaster

Broadcast channels for async web apps. 📢
BSD 3-Clause "New" or "Revised" License
1.13k stars 121 forks source link

Please release lib version #103

Closed ItaloCobains closed 8 months ago

ItaloCobains commented 1 year ago

I need the functionality of a feature that sends the redis url password to asyncio_redis version 0.2.0, but I cloned your repository and saw that it is already available. I have an app in production that really needs this. I'll end up having to open a fork of your app or use another lib if that doesn't work.

0.2.0:

    async def connect(self) -> None:
        self._pub_conn = await asyncio_redis.Connection.create(self._host, self._port)
        self._sub_conn = await asyncio_redis.Connection.create(self._host, self._port)
        self._subscriber = await self._sub_conn.start_subscribe()

current version repo:

    async def connect(self) -> None:
        kwargs = {"host": self._host, "port": self._port, "password": self._password}
        self._pub_conn = await asyncio_redis.Connection.create(**kwargs)
        self._sub_conn = await asyncio_redis.Connection.create(**kwargs)
        self._subscriber = await self._sub_conn.start_subscribe()
Mark90 commented 8 months ago

I'm also wondering if there is any chance a new release can be made?

We'd like to use the rediss:// backend for which a fix is in the master branch. This branch seems to work fine in our application when installing it directly.

Mark90 commented 8 months ago

In case anyone read my previous comment and got their hopes up, using rediss:// actually gives problems in the asyncio_redis library that broadcaster depends on. So I was wrong in saying that master branch works fine (for this particular usecase anyway)

alex-oleshkevich commented 8 months ago

@Kludex let's merge #110 and #111 and publish a new version?

alex-oleshkevich commented 8 months ago

Tracked in https://github.com/encode/broadcaster/issues/113