search

encode / django-vanilla-views

Beautifully simple class-based views.
http://django-vanilla-views.org/
BSD 2-Clause "Simplified" License
985 stars 74 forks source link

DeleteView template name incorrect? #9

Closed rolo closed 11 years ago

rolo commented 11 years ago

Hi Tom. Have been having a play with this, but hit something unexpected - the DeleteView is using the same template name as the DetailView. If it's a typo, here's a fix, if it's by design then I guess it needs documenting somewhere. Seems useful to have it use the same template, as it means it drops into my existing project without any changes, but maybe there's a reason to change it. Cheers dude :)

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling 01d6ba225848a25fdc8186da5a4ff1dd3aad6e80 on wildfish:master into 384fb7983b51e3a9a8d816c3679bea9122791fd9 on tomchristie:master.

tomchristie commented 11 years ago

Thanks, yup exactly right!

tomchristie commented 11 years ago

Pushed to PyPI as 1.0.1. Thanks again :)