encode / httpx

A next generation HTTP client for Python. 🦋
https://www.python-httpx.org/
BSD 3-Clause "New" or "Revised" License
13.28k stars 844 forks source link

Consider dropping HSTS preloading #1102

Closed florimondmanca closed 4 years ago

florimondmanca commented 4 years ago

Prompted by https://github.com/encode/httpx/issues/1025#issuecomment-661269344

Issues like #1025 should prompt us to reconsider whether using HSTS preloading from a server-side client (introduced via #151) is a sensible thing to do at all.

Key points of reasoning here:

Some options are:

Given all the context points above, we might want to just go with option 2).

StephenBrown2 commented 4 years ago

My vote is for Add a toggle so that HSTS preload becomes opt-in, though for 1.0 it might be better to reduce the surface area and drop it entirely.