encode / httpx

A next generation HTTP client for Python. 🦋

https://www.python-httpx.org/

BSD 3-Clause "New" or "Revised" License

12.7k stars 811 forks source link

Open trim21 opened 2 months ago

trim21 commented 2 months ago

Summary

There are several test cases broken on windows.

[X] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
[ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
[ ] I've updated the documentation accordingly.

trim21 commented 1 month ago

coverage failed because this:

io.StringIO is a subclass of io.TextIOBase

trim21 commented 1 month ago

I just use pytest's tmp_path to create a real file on disk. pytest will clean it up after test.