encode / starlette

The little ASGI framework that shines. 🌟
https://www.starlette.io/
BSD 3-Clause "New" or "Revised" License
10.27k stars 939 forks source link

GraphQL integration does not work w/ graphl-core versions > 2 #1144

Closed mecampbellsoup closed 3 years ago

mecampbellsoup commented 3 years ago

Checklist

Describe the bug

When following the Starlette GraphQL docs regarding GraphQL integration, if you install graphql-core versions > 2 (i.e. non-legacy core library), you will see that the module graphql.execution.executors.asyncio.AsyncioExecutor no longer exists.

I asked about this in the GraphQL core project and they indicated that as of graphql-core >=3 the executors had been discarded as they were now async by default, roughly speaking (I'm paraphrasing, please see the issue I linked to for context).

I didn't see any open issues regarding support for the new graphql-core versions - is this in the works, by any chance? The legacy project is now unsupported.

Environment

Additional context

https://github.com/graphql-python/graphql-core/issues/121 https://github.com/graphql-python/graphql-core-legacy

Kludex commented 3 years ago

Starlette deprecated built-in GraphQL support.

Check #1135 for more details.