Use less private imports on the testclient module

encode / starlette

The little ASGI framework that shines. 🌟

https://www.starlette.io/

BSD 3-Clause "New" or "Revised" License

10.31k stars 948 forks source link

Open Kludex opened 2 months ago

Kludex commented 2 months ago

Kludex commented 1 month ago

@tomchristie Can we discuss/have a plan with this before httpx 1.0?

Kludex commented 1 month ago

@zanieb @tomchristie was this discussed in the meeting?

tomchristie commented 1 month ago

To an extent... we did talk about stricter typing. (Which would resolve this, by removing the need for type synonyms)

I'll see about spinning out a design discussion.

Kludex commented 1 month ago

What is expected from Starlette?

tomchristie commented 1 month ago

What is expected from Starlette?

Don't access private implementation details.
Currently, pin to minor point releases, eg. >=0.27,<0.28.
Once we're at 1.0 you'l be able to pin to major point releases, eg. >=1.0,<2.0.