encode / uvicorn

An ASGI web server, for Python. 🦄
https://www.uvicorn.org/
BSD 3-Clause "New" or "Revised" License
8.57k stars 745 forks source link

Delete js folder and remove extra_javascript #2136

Closed MhmoudGit closed 1 year ago

MhmoudGit commented 1 year ago

Summary

I found an issue about the chat button not working on website and there was a suggestion to remove the docs/js files. So I deleted the extra_javascript in mkdocs.yaml and the js folder altogether.

Impact

This will remove the "Open Chat" button from the docs website.

Checklist

zanieb commented 1 year ago

@MhmoudGit thanks for contributing. Which issue are you referring to?

MhmoudGit commented 1 year ago

Hi @zanieb, I did the same PR regarding issue #2303 on starlette and @Kludex asked if I can do the same PR in uvicorn and httpx so I did this one and on httpx as well.

Kludex commented 1 year ago

Can we link the other PRs here? :eyes:

MhmoudGit commented 1 year ago

The one on httpx was approved, merged and closed so only this and starlette are opened for now. Do you mean I should put a link here? or that question wasn't for me? :sweat_smile:

Kludex commented 1 year ago

'-'