encode / uvicorn

An ASGI web server, for Python. 🦄

https://www.uvicorn.org/

BSD 3-Clause "New" or "Revised" License

8.11k stars 701 forks source link

Closed dolfinus closed 1 month ago

dolfinus commented 2 months ago

Summary

Update string % subst usage with f-string. For logging use logger.method(string, subst) instead of explicit message formatting.

[X] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
[ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
[ ] I've updated the documentation accordingly.

baseplate-admin commented 1 month ago

I did a comment on a issue, i don't think this is prioritized at this moment :

dolfinus commented 1 month ago

That comment just asks "why not f-string", and then closed without any discussion or describing a reason why not.

baseplate-admin commented 1 month ago

then closed without any discussion

The thing is i didn't close the comment.

describing a reason why not.

Precisely why i dont think that this formatting issue is not high priority