Closed Kludex closed 1 month ago
This copilot summary is not that helpful.
I've bumped the websockets in the test suite. I also made sure uvicorn continues to work on the minimum version set on the pyproject i.e. 10.4.
I've also added more type hints to the test_websockets.py
.
This pull request includes several changes to the
uvicorn
project, focusing on handling deprecation warnings and refining the WebSocket protocol implementation. The key changes involve the addition of a new filter warning, adjustments to method signatures, and improvements to exception handling in WebSocket communication.Handling Deprecation Warnings:
pyproject.toml
: Added a new deprecation warning filter for thewebsockets
library. ([pyproject.tomlR99](diffhunk://#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R99)
)WebSocket Protocol Implementation:
uvicorn/protocols/websockets/websockets_impl.py
:ws_handler
method signature by removing the multi-line format. ([uvicorn/protocols/websockets/websockets_impl.pyL227-R227](diffhunk://#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L227-R227)
)asgi_receive
method signature for better readability. ([uvicorn/protocols/websockets/websockets_impl.pyL362-R360](diffhunk://#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L362-R360)
)asgi_receive
method to useself.close_code
andself.close_reason
instead of the exception attributes. ([uvicorn/protocols/websockets/websockets_impl.pyL381-R381](diffhunk://#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L381-R381)
)