search

encointer / explorer

explore the encointer network, browse local communitities an monitor populations
GNU General Public License v3.0
1 stars 1 forks source link

fixed the tentative community Growth function #103

Closed Quackaholic-Quacktivity closed 1 year ago

Quackaholic-Quacktivity commented 2 years ago

closes #101

brenzi commented 2 years ago

please always mention the issue a PR is closing. Did it for this one

Something is still odd. Your formula looks alright for me, but when I tested with Leu community, the numbers don't match: image

(12 newbies+16 endorsees)/201 reputables = 13.9%, not 6%

brenzi commented 2 years ago

and I just realized that we probably need to only count newbies that have been assigned (if assignments have been done). As you already feature "newbies unassigned", this should be easy to do?

Quackaholic-Quacktivity commented 1 year ago

Found the problem that we had with the tentative growth function. when we do newbies + endorsees we actually concatenate the two numbers together (why? newbies and endorsees have the type 'any' which might explain the problem). And only using the assigned Newbies shouldn't be a problem.

brenzi commented 1 year ago

I have to assume you didn't test this. Your code now displays 0.11% tentative community growth which probably should be 11%?

image

Quackaholic-Quacktivity commented 1 year ago

yes, honest mistake. Now it should be correct