search

encomage / module-guestbook

Encomage Guestbook module for Magento 2
1 stars 1 forks source link

Pagination not working #2

Closed gewaechshaus closed 5 years ago

gewaechshaus commented 5 years ago

Hey @VadimSapa @andrey-bondarenko ,

the pager doesn't work in our case, it always returns the same collection... Can you verify that?

Greetings Jan

gewaechshaus commented 5 years ago

Returns bool false:

https://github.com/encomage/module-guestbook/blob/df775f8454f95b8b4f9021f69798fbceed47afad/Block/Comments.php#L217

andrey-bondarenko commented 5 years ago

@gewaechshaus

It will be fixed today or tomorrow

gewaechshaus commented 5 years ago

@andrey-bondarenko - thanks! I think the p param is never use to setCurPage and there are some other issues related to the collection object as well.

andrey-bondarenko commented 5 years ago

@gewaechshaus It was a mistake. This functionality hasn't implemented yet. We will implement it for the next week.

gewaechshaus commented 5 years ago

OK

gewaechshaus commented 5 years ago

Hey @andrey-bondarenko - are there any news related to the pagination?

Greetings Jan

andrey-bondarenko commented 5 years ago

@gewaechshaus Hi sorry about that. We have a very high loading now. We will do it ASAP.

Thanks!

gewaechshaus commented 5 years ago

@andrey-bondarenko - may I ask you again about the state of the pagination?

Many thanks, Cheers, Jan

andrey-bondarenko commented 5 years ago

@gewaechshaus Hi, we're going to fix it the next week.

Thanks

gewaechshaus commented 5 years ago

@andrey-bondarenko - sorry for asking again - any news about the state of the pagination?

Cheers Jan

andrey-bondarenko commented 5 years ago

@gewaechshaus Hi, sorry for delay and thanks for waiting. It will be released tomorrow.

andrey-bondarenko commented 5 years ago

@gewaechshaus done. please update module.

gewaechshaus commented 5 years ago

@andrey-bondarenko - many many thanks! We found 2 issues, I will create a PR...

Cheers Jan

andrey-bondarenko commented 5 years ago

@gewaechshaus Great! Thanks!

gewaechshaus commented 5 years ago

https://github.com/encomage/module-guestbook/pull/5

gewaechshaus commented 5 years ago

There's a small issue with the loader, I have to look at it later Expected to start loader but did not find one in the dom