encoredev / encore

Open Source Development Platform for building robust type-safe distributed systems with declarative infrastructure
https://encore.dev
Mozilla Public License 2.0
7.79k stars 331 forks source link

`encore eject docker image:tag` breaks when calling from different drive #1373

Open ryanocf opened 2 months ago

ryanocf commented 2 months ago

encore eject docker ... breaks when calling from different drive

Environment

OS: Windows 23H2 (Build 22631.4037) Encore: v1.40.4 Node: 22.4.1 NPM: 10.8.2 Docker Desktop: 4.33.1

Expected output

Actual output

7:21PM INF compiling Encore application for linux/amd64
7:21PM ERR build docker image: build image fs: copy path: Rel: can't make C:\Users\admin\.encore\runtimes\js\encore.dev relative to D:\Projects\encore-file-upload\node_modules

Reproduce steps

  1. Install encore via the docs
  2. Create an app via encore app create on a different drive than encore is installed with Typescript
  3. Call encore eject docker image:tag

But if you would now just copy the app folder to the same drive encore is installed on, it works just fine. So to visually show the problem:

WORKS

.
└── C:/
    ├── 📁User/
    │   └── 📁admin/
    │       └── 📁.encore/
    │           └── ...
    └── 📁encore-test-app/
        └── ...

DOESN'T WORK

.
├── C:/
│   └── 📁User/
│       └── 📁admin/
│           └── 📁.encore/
│               └── ...
└── D:/
    └── 📁encore-test-app/
        └── ...
niklas-stegmann commented 3 weeks ago

Any news on this? I have the same error with

encore build docker image:tag

encore version v1.43.8