chore(Code): Merge WISE-Client up to Sept 2022 (Tabbed UI) - Githubissues

encorelab / SCORE-Client

Client-side code for SCORE

Other

1 stars 0 forks source link

chore(Code): Merge WISE-Client up to Sept 2022 (Tabbed UI) #23

Closed hirokiterashima closed 1 year ago

hirokiterashima commented 1 year ago

Changes

Sync SCORE-Develop codebase with https://github.com/WISE-Community/WISE-Client, up to commit https://github.com/WISE-Community/WISE-Client/commit/6799e7607492ca89759930d2700f43903b236d89, which is the Tabbed Navigation Theme that was implemented in Sept 2022.

Test Prep

Test this with https://github.com/encorelab/SCORE-API/pull/9
Run npm i to get new dependencies

Test

Test tabbed UI: using JSON editing in the AT, add "theme": "tab" as top-level key/value in project.json. Preview/load as student and make sure that the navigation uses tabs
Test that everything works as before

hirokiterashima commented 1 year ago

I fixed the logo issue. Thanks for noticing it.

Making the next step button visible/disabled based on constraint is a good idea. I'll discuss this with the team and work on it in a separate issue.

Adding a jump to top/bottom button may be useful especially for steps with a lot of components. Let's discuss this further.