search

encounter / dtk-template

Project template for decomp-toolkit
Creative Commons Zero v1.0 Universal
15 stars 13 forks source link

Allow adding re-configure dependencies and doing non-matching builds #22

Closed TheNathannator closed 3 months ago

TheNathannator commented 3 months ago

Additional re-configure dependencies can now be added in the project config. For example, for rb3, we moved object configuration to a pair of objects.json and flags.json files so we can configure things per-version, and edits to these files need to cause a re-configure.

Additionally, a non-matching build can now be performed by passing the --non-matching argument to configure.py. This skips the hash check and progress output, since those don't make sense to run in this configuration. A new Equivalent object status has also been added, which will make an object be built and linked only in this configuration.

I also fixed a small type-checking issue in configure.py, config.version was still an Optional[str] after being set from args.

cadmic commented 3 months ago

For non-matching, what about changing the default target to be the dol instead of neutering the check and progress targets?

encounter commented 3 months ago

Thanks for the PR! I agree with cadmic that adjusting the default target would be more ideal. Otherwise looks good.

TheNathannator commented 3 months ago

For non-matching, what about changing the default target to be the dol instead of neutering the check and progress targets?

I'm not familiar with Ninja, so I never considered this as a possibility. That definitely sounds like a better option.

encounter commented 3 months ago

Looks good, thanks!