search

encounter / objdiff

A local diffing tool for decompilation projects
Apache License 2.0
77 stars 13 forks source link

Check extab/extabindex size equivalency #36

Closed vabold closed 6 months ago

vabold commented 6 months ago

The current behavior appears to ignore extab/extabindex when determining if an object is complete. An example is seen here: image

The rest of the file is generated correctly, and objdiff marks it complete: image

The mismatched size leads to a mismatch in overall section size, so the expected behavior would be to mark the object as incomplete.

encounter commented 6 months ago

The "complete" flag in objdiff is pulled from the build script. If it's marked as "Matching" there, it'll show up green in objdiff. It's merely a way to visualize which files are linked, rather than diffing each file and somehow determining equivalency.