encounter / objdiff

A local diffing tool for decompilation projects
Apache License 2.0
77 stars 13 forks source link

Use base arch when processing base code #62

Closed AetiasHax closed 1 month ago

AetiasHax commented 1 month ago

When diffing target against base, the diff_code function uses the target arch object to process code for both target and base, and the base arch object goes unused.

From what I can tell, all currently supported architectures have the same parameters in the two arch objects, so it doesn't matter which one gets used to process code. However, I'm working on supporting ARMv5TE, and my arch objects can have different parameters.

encounter commented 1 month ago

Good catch, thanks!