encratite / RiotControl

An elaborate statistics tracking system for League of Legends. It used to be a centralised PostgreSQL based system but now it's a stand-alone SQLite application. It was written in C# and makes use of the LibOfLegends RTMP library. It is licensed under the terms of the GPLv3. Unfortunately I stopped working on it in 2013-08. Check out the website for a longer explanation.
http://riot.cont.ro.lt/
GNU General Public License v3.0
33 stars 15 forks source link

"unknown_player" is updated incorrectly #38

Closed encratite closed 12 years ago

encratite commented 12 years ago

UpdateSummonerGame.cs says:

                                        //It's called summonerId but it's really the account ID (I think)
                                        missingPlayer.Set("account_id", player.summonerId);

But it is actually the summoner ID and not the account ID from what I've gathered now. This forces us to write "upgrade" code for the RiotGear library that automatically renames this column from account_id to summoner_id. This needs to be updated, too:

                        using (var delete = Command("delete from unknown_player where team_id = :team_id and account_id = :account_id", connection))
                        {
                            delete.Set("team_id", summonerTeamId);
                            delete.Set("account_id", summoner.AccountId);
                            delete.Execute();
                        }

And even after doing that, I still have another problem. I am currently unable to make getAllSummonerDataByAccount in LibOfLegends work. It always returns null, no matter what ID I use it with. It doesn't work with the account ID nor with the summoner ID, it seems. This might also be a bug in LibOfLegends or (which is more unlikely) a permanent change in the League of Legends protocol.

encratite commented 12 years ago

Fixed in https://github.com/epicvrvs/RiotControl/commit/c5cac0adf4065f3e966ff72286193ffa02824cac