encryptic-team / encryptic

An encryption-focused open source note taking application
Mozilla Public License 2.0
348 stars 40 forks source link

Prefix application startup with dumb-init #120

Closed rangerelf closed 1 year ago

rangerelf commented 4 years ago

Sorry for the cold-pull-request, I'm not too well versed in github pull request etiquette; thanks for this project, it's great, I've been looking for something like this for the longest time and suddenly saw it today in r/selfhosted.

While testing the docker build and docker run on the command line I found that the container wouldn't stop when I pressed ^C, so I added dumb-init to the application initialization and that fixed it. It'll make application exit cleaner, since docker won't have to kill the process without giving it a chance to clean up after itself.

Dumb init is developed here: https://github.com/Yelp/dumb-init