encryptic-team / encryptic

An encryption-focused open source note taking application
Mozilla Public License 2.0
348 stars 40 forks source link

v0.0.1 Feedback #3

Open daed opened 5 years ago

daed commented 5 years ago

See release at: https://github.com/encryptic-team/encryptic/releases/tag/v0.0.1

I want this issue to be a feedback thread for the project release. I'm probably going to do one of these for each release I make for a while, at least, until we have a solid version together with all the basic features ticked off.

funilrys commented 5 years ago

How do we generate binaries from source ? :smile_cat: Laverna was generating a binary called laverna which can be called :smiley_cat: I built from source but I did not found anything after running gulp build :joy_cat:

This is for sure a low priority but just wanted to state it :smile:

daed commented 5 years ago

There are a few important commands that really should be documented better somewhere else. gulp build - Builds the css / html files and does the webpack stuff. gulp serve - Starts up the server using what's built by the build command. gulp release - Runs gulp build and then installs electron packages and puts the binaries together.

Also, just running gulp will implicitly do a build and serve. There are also cleaning processes, but those are run automatically by build and release.

For the purposes of this release, I am uploading the binaries as we speak. :)

funilrys commented 5 years ago

Understood!

What is the license of this project ?

funilrys commented 5 years ago
daed commented 5 years ago

Wow, that got noticed fast!

I was taking a look at options before I added it back in. I guess I forgot to. The MPL has been added to the project.

That's probably best as that's what the original code was licensed under and it seems overall incredibly reasonable and straightforward..

funilrys commented 5 years ago

@daed, is it also into the release package ? (If not do not add it to 0.0.1 I'll merge it directly)

daed commented 5 years ago

It is not in the release package. I'm not 100% sure gulp is set up to put it there even if it was.

I'll get that changed ASAP for next time.

The license should get inserted into the release from here on.

iAmGhost commented 5 years ago

Importing Laverna exported database(from original Laverna Beta v0.7.51) doesn't work.

On intro page(that has import/create account option) it fails with console output: lav:components/importExport/Import error +32s You need to create a profile first!

When importing after creating account(on settings page) this happens:

lav:components/importExport/Import error +1m TypeError: Cannot read property 'async' of null
    at Import.importProfile (Import.js:316)
    at Import.import (Import.js:299)
    at readZip.then.zip (Import.js:138)
    at <anonymous>
daed commented 5 years ago

Are you trying to import from the laverna beta I forked at https://github.com/daed/laverna or the original version from https://github.com/Laverna/laverna?

I'm seeing issues with the import/export process with both. I'm pretty sure I know a fix for the daed/laverna one (working on that now) but I'm running into issues with the laverna/laverna version.

iAmGhost commented 5 years ago

Are you trying to import from the laverna beta I forked at https://github.com/daed/laverna or the original version from https://github.com/Laverna/laverna?

I'm seeing issues with the import/export process with both. I'm pretty sure I know a fix for the daed/laverna one (working on that now) but I'm running into issues with the laverna/laverna version.

I was trying to import from original one(Beta v0.7.51).

daed commented 5 years ago

Interesting. I get something completely different (ASCII armor error) when I try to import my personal backup from that version. I suspect I might have weirdness going on with my data though.

The reason why the laverna import fails at the signup level import is because the laverna backup doesn't contain a recognizable profile. No username, no private key, so it chokes. There's a bug in there where we don't check for laverna (dev branch) profiles because I renamed them to encryptic, but that doesn't affect 0.7.51, only the versions I built, so I've got that fixed but it's not your problem.

Even so I'm not 100% sure it would work at that stage because even if it did, you'd still lack the profile. There's a few solutions to that, but they all have drawbacks. I think I'm going to settle on the "don't do that" solution and ask that people use the import once they've created a profile and logged in. You're still seeing issues there so there's still a problem that I need to dig further into, but that's better than trying to import at the initial signup.

Working further up the stack trace, at Import.import you've gone down the wrong branch already. That looks like another victim of my overzealous find/replace for instances of laverna. I can probably have that fixed this evening and at least committed to master if not a full release yet. Broken imports is kind of a showstopper though, so I'd want to release soon.n This probably should have been a separate issue logged.

Stay tuned, I'll have an update within a day or so.

daed commented 5 years ago

Took a bit longer than I was hoping for, but I'm pretty confident that it's fixed now in the repo and at https://app.encryptic.org. I had to rewrite a significant portion of the import code. I will put out a new electron release when I get a moment.

I will get this better documented in the future, but for the time being if you are looking to migrate from Laverna v0.7.51, go ahead and create your new user in Encryptic, go to your settings, and then run the "Recover from Backup" option there. It should read your old Laverna stuff and then trigger the migration view asking for your Laverna password to do the decryption. After your notes should be present under your login.

I tested it with a clean Laverna backup that just had a couple notes, a notebook, and a few tags, and then I tested it with my personal one I've been using for over a year now. Seemed to work with both so I think it's good to go.

dayfuaim commented 5 years ago

Version: 0.1.0 (Current) Mac OS X 10.10.5

Everything works as been told in release note.

I have suggestion on packaging. Here is the screenshot of "downloaded .app – local build" side-by-side compare: Снимок экрана 2019-07-12 в 15 30 34 As it can be seen, local build has symlinks for frameworks, whereas packaged app has the whole files/dirs. Symlinks save much space (especially in case of Electron libs), almost 3x. So, my suggestion is to pack archive containing symlinks (ZIP can do this).

daed commented 5 years ago

I noticed that the Mac version was quite a bit larger than the others. I'll check that for the future.