Upgrade to Marionette 4

encryptic-team / encryptic

An encryption-focused open source note taking application

Mozilla Public License 2.0

348 stars 40 forks source link

Upgrade to Marionette 4 #31

Closed Maks-s closed 5 years ago

Maks-s commented 5 years ago

Upgrade done by following https://marionettejs.com/docs/v4.0.0/upgrade-v3-v4.html

Maks-s commented 5 years ago

I'm also going to upgrade all other dependencies, would you prefer everything in 1 PR or 1 PR for each upgrade ?

funilrys commented 5 years ago

I do think that for each may be better but will let @daed decide ...

daed commented 5 years ago

Thanks for the page @funilrys. I got behind during the holiday.

@Maks-s The simple ones that are one or two minor code changes would be fine all put together in one PR. For the things that require lots of changes (like gulp) I'd prefer to get in individual PRs.

I'll have a look at this and (I imagine) approve it shortly. Thanks for your help!