Closed Maks-s closed 5 years ago
About vscode It's may be a good idea to include it with a setting configuration and module we may use so that we all have the same dev environment :thinking:
... Just an idea ...
I had the idea after hitting Ctrl+S for saving under vscode ... Part of the code was formatted automatically ... :disappointed:
Good idea @funilrys
Also, should we force LF on windows to prevent massive errors from eslint (because of CRLF) or should we remove the linebreak-style rule from eslint ?
The problem with LF is actually more complicated because everybody should actually commit/push with LF instead of CRLF.
I think that we should do https://eslint.org/docs/rules/linebreak-style#using-this-rule-with-version-control-systems
.gitattributes:
*.js text eol=lf
Before adding Travis CI we should do #8 😉
I think a lot of this was on me. I went through and cleaned up a bunch of the eslint errors and then made a bunch more with the intent of getting back to them eventually. I'll get into better habit about that.
The PR looks good. Merging.
The title says it all 😃
Small tweaks / fix included which didn't need their own PR :