search

encryptic-team / encryptic

An encryption-focused open source note taking application
Mozilla Public License 2.0
348 stars 40 forks source link

Replace gulp-util #64

Closed fosslinux closed 5 years ago

fosslinux commented 5 years ago

gulp-util is now deprecated, it should be replaced.

gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

Maks-s commented 5 years ago

gulp-util is already removed, see #42

fosslinux commented 5 years ago

Hmm, it can't be removed fully, because when I tried to build it I got an error that gulp-util was required.

daed commented 5 years ago

It's sneaking back in via gulp-electron. I'll see about alternatives.

daed commented 5 years ago

I created a new branch called electronPackaging in which I rewrote the electron packaging gulpfile so that we could remove gulp-electron (which was bringing in gulp-utils) and also gulp-manifest, which we weren't actually using but still had gulp-utils as a dep.

My new gulp appears to work more or less properly except when it comes to the final repackaging in zip files. For some reason the zip is corrupt upon reading. Also, I think I need to find out how the platformResources are being used.

I will take a further look at this after sleep and merge this when I get it functional.

daed commented 5 years ago

As of the merge I did earlier, this is squashed.