search

encryptic-team / encryptic

An encryption-focused open source note taking application
Mozilla Public License 2.0
348 stars 40 forks source link

Clicking Link Opens Site, Losing Encryptic Access #94

Open johnblommers opened 5 years ago

johnblommers commented 5 years ago

We all create Markdown notes with website URLs. But if you click such a link the entire Encrypted application's face is replaced with the website. There is no way back to Encrypted. There is no back button, no back keyboard shortcut, no solution other than to quit Encrypted, restart and login again.

Is it possible to always open links in the system default browser instead of in Encrypted? On macOS at least it is a convention to hold down the Command key and then click the link to open the URL in the system browser.

daed commented 5 years ago

This is similar to the dropbox oauth issue I had to work around a while ago. The problem is that the encryptic code doesn't realize it's being run in electron. There's no real way to trigger a new system browser load from the url without having electron code to handle it.

It might be doable, but I don't honestly know how, and I spent a lot of time trying to figure it out during the oauth thing. The alternative is to create divergent code for electron Encryptic vs hosted Encryptic, which was something I was trying to avoid for as long as possible.

johnblommers commented 5 years ago

It's my sense that you should consider working on more important items in the list of issues. No data is lost so it's no gnashing of teeth or rending one's clothes moment. Restarting Encrypted is quick so it's a minor inconvenience to work around the mis-click.

Out of complete naivety I would ask for a "back button" or a keyboard shortcut but I'm willing to bet you've already wrestled with the idea.

daed commented 5 years ago

Sorry it's taken me a while to get back to this. The next version will have Ctrl (or Cmd) + B to go back, and there will also be a "back" option in the hidden menu (press alt to reveal it). That's a stopgap until I can work out how to actually make the behavior less horrible for urls.

daed commented 5 years ago

Actually, I think I nailed it. I think this will help Dropbox authentication too. Still won't be seamless, but it'll be much better than it was.

daed commented 5 years ago

New changes should be in the v0.1.0 release. Have a look and see if that fixes your concerns.