search

encukou / py3c

A Python 2/3 compatibility layer for C extensions
http://py3c.readthedocs.org
MIT License
59 stars 20 forks source link

Switch most of CI to GitHub Actions #39

Closed encukou closed 3 years ago

encukou commented 3 years ago

This includes PR #38, where Travis CI is taking a really long time to run all the builds.

encukou commented 3 years ago

@hroncok, would you have time for a quick sanity check?

encukou commented 3 years ago

The Travis CI build failed on Python 3.7, which is no longer compatible with c90 – the error comes from a CPython header. The new GH action removes py37-c90.

hroncok commented 3 years ago

This includes PR #38

GitHub presents the thing in a confusing manner. That PR appears to be merged but the commits are still displayed here. Anyway, reviewing the CI related commit only here.

encukou commented 3 years ago

Thanks for the review!

The first gcc actually uses C++ because of the extension of test_py3c.cpp (which is a symlink to test_py3c.c, made just for this).

encukou commented 3 years ago

Alas, Python 3.4 is no longer in Fedora.

hroncok commented 3 years ago

Right, OMG.

encukou commented 3 years ago

OK! Looks like we can use Travis for 3.4 and an ancient container image for Python 3.3.

encukou commented 3 years ago

I wonder whether it won't make more sense to do the 3.4 job on GH actions as well?

Gerrit Huizenga convinced me to keep Travis CI, or at least a bit of it. See this discussion for the details.

encukou commented 3 years ago

Thank you for the review and all the suggestions! But I don't want to drag this out longer. This PR now makes things better than they were, so I'll merge. Discussion can continue, of course :)